messageTray: fix summary area wobbling

Due to accumulation of rounding errors, the left edge of the summary area
could wobble by a few pixels during animations. Fix that.

https://bugzilla.gnome.org/show_bug.cgi?id=636930

diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index 8a29597de7fa42451aec9b1715c43f9c2b50732f..c105d4df640f58544e5ffe446a82fb98174d3825 100644 (file)
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -1339,6 +1339,8 @@ MessageTray.prototype = {
     },
 
     set _expandedSummaryItemTitleWidth(expansion) {
+        expansion = Math.round(expansion);
+
         // Expand the expanding item to its new width
         if (this._expandedSummaryItem)
             this._expandedSummaryItem.setTitleWidth(expansion);
@@ -1369,11 +1371,32 @@ MessageTray.prototype = {
             if (this._summaryItems[i] == this._expandedSummaryItem)
                 continue;
 
-            let width = this._summaryItems[i].getTitleWidth();
-            this._summaryItems[i].setTitleWidth(width * shrinkage);
+            let oldWidth = this._summaryItems[i].getTitleWidth();
+            let newWidth = Math.floor(oldWidth * shrinkage);
+            excess -= newWidth;
+            this._summaryItems[i].setTitleWidth(newWidth);
+        }
+        if (this._expandedSummaryItem) {
+            let oldWidth = this._imaginarySummaryItemTitleWidth;
+            let newWidth = Math.floor(oldWidth * shrinkage);
+            excess -= newWidth;
+            this._imaginarySummaryItemTitleWidth = newWidth;
+        }
+
+        // If the tray as a whole is fully-expanded, make sure the
+        // left edge doesn't wobble during animation due to rounding.
+        if (this._imaginarySummaryItemTitleWidth == 0 && excess != 0) {
+            for (let i = 0; i < this._summaryItems.length; i++) {
+                if (this._summaryItems[i] == this._expandedSummaryItem)
+                    continue;
+
+                let oldWidth = this._summaryItems[i].getTitleWidth();
+                if (oldWidth != 0) {
+                    this._summaryItems[i].setTitleWidth (oldWidth + excess);
+                    break;
+                }
+            }
         }
-        if (this._expandedSummaryItem)
-            this._imaginarySummaryItemTitleWidth *= shrinkage;
     },
 
     _expandSummaryItemCompleted: function() {